Skip to content

Remove position sticky polyfill

Lukas Eipert requested to merge leipert-remove-sticky-polyfill into master

What does this MR do?

  • Remove position sticky polyfill from changes dropdown

  • Remove sticky polyfill from Merge Request Page

  • Remove sticky polyfill from job logs page

  • Remove sticky polyfill from dependencies

The sticky polyfill stuck around long enough and we can remove it, as all browsers we claim to support support position: sticky

Screenshots (strongly suggested)

Tested it with Firefox, Chrome and the two oldest browsers we currently claim to support, Safari 12 and Edge 17. Only recorded the "after" with all those browsers to show that the sticky behaviour still works:

Browser Before After
Firefox sticky-before sticky-after
Chromium - sticky-after-chromium
Safari 12 - sticky-after-safari-121
Edge 17 - sticky-after-edge-17

Here is also a screencast that shows that the "Merge Request Tabs" (Overview, Commits, etc) are still non-sticky in a smaller viewport:

Before After
non-sticky-mobile-before non-sticky-mobile-after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert

Merge request reports

Loading