Update code review process to use reviewers
What does this MR do?
This is a proposal to update our current code review process to use Reviewers feature consistently. See https://docs.gitlab.com/ee/user/project/merge_requests/getting_started.html#reviewer for more detail about the feature itself.
I believe we have too much confusion around how to use this feature since the current Reviewer doesn't dictate how it should be used.
I believe we can still gain some benefits of using Reviewers feature this way until the Reviewer feature develops further.
Basically, this MR suggests that we should use Reviewer as we would with Assignee, but use it only for requesting reviews.
Related to #292938 (comment 510601705) https://gitlab.slack.com/archives/C02PF508L/p1613450890046500
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team