Skip to content

Add page specific styles to project discover security page

Jannik Lehmann requested to merge jnnkl-project-discover-carousel into master

What does this MR do?

This MR solves #321693 (closed)

This bug was introduced while the security discover page carousel was refactored to use page specific styles in !51704 (merged). Unfortunately it was forgotten to include the page specific styles for both of our security discover carousels (one on group level the other one on project level).

This MR fixes that.

How to reproduce:

  1. Identify a project for which the Discover Security page should be visible for you; in practice, that means:
  2. Visit the Discover Security page for the project, e.g., https://gitlab.com/a-group-you-own/some-project/-/security/discover

Screenshots (strongly suggested)

before after
Screenshot_2021-02-17_at_14.34.49 Screenshot_2021-02-17_at_14.35.22

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jannik Lehmann

Merge request reports

Loading