Skip to content

Improve Vulnerability Tracking: Store Fingerprints

James Johnson requested to merge improve_vuln_tracking-backend_store_only into master

This MR is the first phase of the backend implementation of the proof-of-concept MR: !45339 (closed) and is part of the epic https://gitlab.com/groups/gitlab-org/-/epics/4690 - Improve Vulnerability Tracking: MVP: Scope+Offset

What does this MR do?

This merge request uses the database table added with !52720 (merged) to only store vulnerability tracking fingerprints.

Using the stored fingerprint values will be implemented in a follow-up MR and will be placed behind a feature flag.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Database Migration Output

 lptp [ gitlab ]: bundle exec rake db:migrate:up VERSION=20210218142626 ENV=development
== 20210218142626 ChangeFindingFingerprintEnum: migrating =====================
-- change_column(:vulnerability_finding_fingerprints, :algorithm_type, :integer, {:limit=>2})
   -> 0.0266s
== 20210218142626 ChangeFindingFingerprintEnum: migrated (0.0267s) ============

 lptp [ gitlab ]: bundle exec rake db:migrate:down VERSION=20210218142626 ENV=development
== 20210218142626 ChangeFindingFingerprintEnum: reverting =====================
-- change_column(:vulnerability_finding_fingerprints, :algorithm_type, :integer)
   -> 0.0303s
== 20210218142626 ChangeFindingFingerprintEnum: reverted (0.0304s) ============

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by James Johnson

Merge request reports