Add RedisHLL errors into Usage Ping Redis hardening
What does this MR do?
Part of #300535 (closed) and suggested in !52334 (comment 496946395)
There are instances (e.g. in Gitlab::UsageData) of passing HLLRedisCounter to the block in Gitlab::Utils::UsageData#redis_usage_data and its errors wouldn't be rescued to return fallback value. This would potentially result in failing the entire Usage Ping generation.
This prevents that and hardens the method. All HLLRedisCounter custom exceptions are rescued, since EventError is their superclass.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #300535 (closed)
Edited by Piotr Skorupa