Skip to content

Fix error when rendering project pipeline status

What does this MR do?

project.last_pipeline always queries the DB for the last pipeline so the project.last_pipeline.present? check does not ensure that project.last_pipeline exists when we call project.last_pipeline.detailed_status(current_user).

We fix this by saving the last pipeline to a local variable so that #present? and #detailed_status are called on the same object.

Related to #321939 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports

Loading