Skip to content

Clarify that exclude_internal includes project bot users

Brie Carranza requested to merge bcarranza-master-patch-68758 into master

What does this MR do?

In working on a ticket, I noticed that exclude_internal excludes internal bots but does not exclude project bot users. For those very familiar with how we define internal users, this is fine. However, this was not immediately clear. I aim to deflect a few tickets via documentation with this MR.

Semi-related, after the introduction of the project bot user, we opened an issue about logical categorization of Bots. Once that's closed, some additional work may need to be done on this doc.

Screenshots (strongly suggested)

Here's an example response using exclude_internal which shows project bot users.

Screen_Shot_2021-02-19_at_12.21.25_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading