Skip two factor setup for help pages
What does this MR do?
Fixes #259974 (closed)
Minor bug fix that allows help/documentation pages to be accessible by an authenticated user who is otherwise required to enable 2FA. The action we're bypassing is from EnforcesTwoFactorRequirement
This does not bypass the 2FA requirement on sign-in, or negate the requirement for a user to configure 2FA when they access any other area of GitLab. It just allows documentation to be available, just like it is to unauthenticated users. A user brought this up because they wanted to check documentation as they were configuring 2FA but could not because it kept redirecting them back to setup 2FA. See #259974 (closed) for more details.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team