Skip to content

Better ReleaseHighlight validation

Jay requested to merge jswain_whats_new_better_url_validation into master

What does this MR do?

The ReleaseHighlight validator will now actually request the image_url and url of each highlight upon validation.

  • added whats_new files to danger to run the test suite upon a new file
  • fixed tests that were stubbing the wrong arguments (syms not strings)

part of: #322668 (closed) #322669 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading