ES Migration add permission data to notes documents (2nd attempt)
requested to merge 300351-remove-joins-from-the-elasticsearch-query-for-project-group-scoped-notes-comments-search-2 into master
What does this MR do?
Related to #300351 (closed)
Resubmit the Elasticsearch migration (it was only run in staging) that was reverted: !55102 (merged)
The issue which caused the revert will be fixed in: !55111 (merged)
The Elasticsearch migration backfills project permissions for Note documents.
Changes from previous MR
- Specifically target the searchable Note types (Issue, MergeRequest, Snippet, and Commit). This will ensure:
- only searchable note types are modified
- reduce time taken for the migration since we are processing less documents
- fix a spec issue with how notes were being created and update spec to verify only the searchable note types affect the
completed?method
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Terri Chu