Fix the nature of FactoryBot traits that create associations of Namespace [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
I noticed this discrepancy while working on a different issue and this MR fixes the problem I noticed.
Problem
$ rails console -e testIn a Rails console session
Namespace.count # says 0
NamespaceSetting.count # says 0
FactoryBot.create(:namespace, :with_namespace_settings) # create a new namespace with an associated namespace_setting record.
# check counts again
NamespaceSetting.count # says 1, all good.
Namespace.count # says 2, should have been just 1!! not good.
This means that whenever these traits are called, it is creating an extra namespace record from their own factory, which can be avoided, which is the purpose of the MR.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Manoj M J