Feat(incidents): add issue state to alerts table
What does this MR do?
A tiny MVC for #228733 (closed) to add the status of an issue to the alert table alongside its issue number.
We handle this by doing a few things:
- Swapping the
issue_iid
on thealert_type.rb
for the fullissue
itself. - Add a preload lookahead to the
alert_resolver.rb
to stop any N+1 issues and add specs to cover it as prescribed: https://docs.gitlab.com/ee/development/api_styleguide.html#verifying-with-tests - Break out the alert issue into a separate set of specs for easier code management.
- Update the Alert management, details component, and the corresponding specs to use the
issue
object to accessiid
and state rather than justiid
.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #228733 (closed)
Edited by David O'Regan