Skip to content

Revert migrating bootstrap modal for file uploads

Brandon Labuschagne requested to merge revert-141da19f into master

What does this MR do?

Reverts the changes introduced to migrate the bootstrap modal for file uploads !53623 (merged)

The changes need to be reverted because a use case was missed with the migration. The file upload button, next to the add license / readme, etc buttons no longer works as a result of this change.

I need to find out the conditions that are required in order to display the file upload button and then ensure that that is working too before we re-merge these changes.

Ref: https://gitlab.slack.com/archives/CETG54GQ0/p1614718138143200

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Brandon Labuschagne

Merge request reports

Loading