Skip to content

fix: Track and raise StoreReportService on all AR errors

What does this MR do?

Update Security::StoreReportService to capture all AR errors rather than just RecordInvalid ones. The original rescue was added with !29723 (merged), but we have previously missed ActiveRecord::NotNullViolations as well, see logs: https://log.gprd.gitlab.net/app/discover#/doc/AWNABDRwNDuQHTm2tH6l/pubsub-sidekiq-inf-gprd-001472?id=xzjL8HcBE8luX0WL3y1L

Relates to #323221 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lucas Charles

Merge request reports

Loading