Skip to content

Add reviewers detail to merge request unmergeable email

What does this MR do?

This MR adds reviewer information to text version of merge request unmergeable email. I initially found it strange to only have more information in the text version, but I see the point of text version being not as clickable as mentioned in #300750 (comment 520001286)

Screenshots (strongly suggested)

HTML version: (not changed)

Screen_Shot_2021-03-03_at_4.51.11_pm

Text version: (changed)

Screen_Shot_2021-03-03_at_4.51.00_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #300750 (closed)

Edited by Mayra Cabrera

Merge request reports

Loading