Migrate bootstrap File Upload modal to GlModal
requested to merge 254280-replace-bootstrap-modal-trigger-in-app-assets-javascripts-blob-blob_file_dropzone-js into master
What does this MR do?
This MR migrates the repo and details upload file dropdown buttons from using a boostrap modal to a gitlab-ui GlModal based component.
This MR has been made simpler by merging the 2 standalone components in:
And the Details button experiment in !56084 (merged)
This was originally merged in !53623 (merged) but had to be reverted due to a missing use case - the upload file button on the projects details.
There are no new changes in this MR since the revert, so it should be good to merge
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. - [-] I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #254280 (closed)
Edited by Brandon Labuschagne