Skip to content

Resolve "MR Changes Cog dropdown checkboxes alignment broken"

Thomas Randolph requested to merge tor/defect/mr-cog-checkboxes into master

What does this MR do?

For #323313 (closed)

A recent change to the GlFormCheckbox layout uses padding to leave space for the actual checkbox element.

This has broken anything that used padding utility classes to position the component.

This MR switches to left margin instead of left padding to recreate the previous layout.

Screenshots (strongly suggested)

Before After
before image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph

Merge request reports

Loading