Draft: Replace anchor_icon in favor of GitLab SVG
What does this MR do?
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category | Reviewer | Maintainer |
---|---|---|
backend |
Roy Zwambag (@rzwambag ) (UTC+2, same timezone as @leipert ) |
Vasilii Iakliushin (@vyaklushin ) (UTC+2, same timezone as @leipert ) |
frontend |
Eduardo Sanz-Garcia (@eduardosanz ) (UTC+2, same timezone as @leipert ) |
Frédéric Caplette (@f_caplette ) (UTC-4, 6 hours behind @leipert ) |
UX |
Philip Joyce (@philipjoyce ) (UTC+1, 1 hour behind @leipert ) |
Maintainer review is optional for UX |
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel fr
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert