Fix GitLab trial project template incorrect menu item
requested to merge 323246-learn-gitlab-template-project-with-incorrect-onboarding-instructions into master
What does this MR do?
Learn GitLab template project with incorrect onboarding instructions
Related to #323246 (closed)
Manual Testing
- Enable the trial onboarding experiment
Feature.enable_percentage_of_time(:trial_onboarding_issues_experiment_percentage, 100)
- Start here http://localhost:3000/-/trial_registrations/new?glm_source=about.gitlab.com&glm_content=free-trial
- You must complete all the trial steps, with a working CustomersDot local installation. Finally when you arrive at "Learn GitLab - Ultimate trial" board, you should see that the "Set up your profile and set your status" is fixed.
Onboarding | Fix |
---|---|
Project template creation
- Put the the
make.sh
file andproject.json
next to each other in a folder. - Use
/make.sh A9 git@gitlab.com:kcomoli/learn-gitlab.git
to create versionA9
. - Copy the generated
A9/learn_gitlab.tar.gz
under/vendor/project_templates
, overriding the existinglearn_gitlab.tar.gz
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alper Akgun