Create Cop to enforce using policies framework for administrators
What does this MR do?
Add a new Cop that blacklists using User#admin? on the codebase, which does not use the policies framework and hence ignores admin mode (when enabled via feature flag, soon migrated to be an application setting).
The todo list file also gives a nice overview of all the places admin? is still used that need to be considered carefully to be migrated in the future. Probably some of them are legit uses.
Related #207950
/cc @bufferoverflow @ifarkas @reprazent @petermarko
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Diego Louzán