Skip to content

Valid issue closing pattern docs example

Timothy Jones requested to merge zmthy/gitlab:zmthy-master-patch-80509 into master

What does this MR do?

The suggested addition for gitlab_issue_closing_pattern to gitlab.rb produces a different regular expression than expected because it is encoded as a Ruby string, so escapes produce different results. This change writes the regular expression in Ruby's Regexp syntax and then converts it to the source string to preserve the syntax of the regular expression with the following YAML example.

Related issues

After a search for gitlab_issue_closing_pattern in the issue tracker, I believe this is the solution to #218641 (closed).

Author's checklist (required)

Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.

When applicable:

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

For more information about labels, see Technical Writing workflows - Labels.

For suggestions that you are confident don't need to be reviewed, change them locally and push a commit directly to save others from unneeded reviews. For example:

  • Clear typos, like this is a typpo.
  • Minor issues, like single quotes instead of double quotes, Oxford commas, and periods.

For more information, see our documentation on Merging a merge request.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Amy Qualls

Merge request reports

Loading