Expose enough shifts records to fill an on-call schedule
What does this MR do?
This MR addresses the issue raised in https://gitlab.com/gitlab-org/gitlab/-/issues/322137#note_514458358.
Our default GraphQL request to populate an on-call schedule should include enough shifts to cover the entire time range. The default 100
records isn't enough to cover many hour-length on-call shifts in the two-week view.
It's not the ideal choice to up the max_page_size
, but it's a calculated decision for the MVC of on-call schedule management and we can try a different option in the future if we encounter excessive performance issues.
Screenshots
The 1st and 3rd rotations get cut short due to the default 100
record limit, even though the shifts should continue.
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this UI is still behind a feature flag.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team