Skip to content

ES Migration to add notes permission data to documents (attempt 3)

What does this MR do?

Related to #300351 (closed)

Advanced Search Migration backfills project permissions for Note documents.

This MR was recently reverted in !55878 (merged). It was reverted due to encountering Notes on Commits in the index where the Commit object had been deleted.

Changes from previous work:

  • Change to using noteable_type instead of noteable to figure out what permission data to index (in as_indexed_json). For commit notes where the commit was null, noteable was null while noteable_type was still set to Commit.
  • Add a new exception to allow the bulk indexer to remove orphaned data
  • Raise that exception when as_indexed_json is called for Notes on Commits where the commit is not found (and as a result, noteable is null)
  • Update/add specs

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Terri Chu

Merge request reports

Loading