Remove .block class from right sidebar blocks
What does this MR do?
Fix for #300787 (closed) and #300190 (closed)
This change removes the .block class from the right sidebar on the job page. Removes some unused CSS in the buttons
Why?: The block class has two meanings: as display: block and as a section in the sidebar which made changes confusing. This change removed both cases in favor of utility classes.
Screenshots (strongly suggested)
The only expected change is a change in the tone of gray of the border in the sidebar, as the original color is not present in our design system.
before (border separator #e8e8e8) |
after (border separator #dbdbdb / gl-border-t-gray-100) |
|---|---|
 |
 |
Small refactor in the buttons lead me to a change in a icon size:
| before | after (icon size adjustment) |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry to indicate a small icon change.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #300787 (closed)