Skip to content

Alert integration UX cleanup - 3rd part

To check navigate to Settings > Operations > Alerts expand section or the direct link will be localhost/group/project/-/settings/operations#js-alert-management-settings

What does this MR do?

It is the third part (now 4th item in a list of improvements for this plan #300827 (comment 512944854))

There is a couple of small items fixed in the scope of this MR

  1. Adds form validation 2021-03-15_19.04.04

Screen_Shot_2021-03-15_at_19.09.37

  1. Disables submit button when form is invalid or not dirty

  2. Adds alert on successful integration creation

2021-03-15_19.05.13

  1. Shows modal on send test alert Screen_Shot_2021-03-18_at_21.16.08

  2. Adds Send& test button back

  3. Does minor refactoring

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #300827 (closed)

Edited by Olena Horal-Koretska

Merge request reports

Loading