Remove secret_detection_default_branch job
What does this MR do?
This MR collapses two Secret Detection jobs into one, secret_detection, by moving the job logic from rules to script. This alleviates the confusion that customers have experienced with the Secret Detection product.
This change is considered a breaking change and should be released with %14.0 as proposed in #273620 (closed)
Screenshots (strongly suggested)
Secrets Detection Default Branch:
Secret Detection Multiple Commits:
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #297269 (closed)
Edited by Zach Rice