Remove `vue_project_members_list` feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Related to #299954 (closed)
Removes the vue_project_members_list that was enabled in %13.8 on gitlab.com and defaulted to on for the %13.9 release. This feature flag was used to convert the project members view from HAML to Vue. There have been no know issues since this feature flag has been enabled so it is time to remove the feature flag from the codebase. This MR also removes unused HAML templates, JavaScript and feature specs.
Note about the feature spec changes
This was a difficult change because we needed feature specs for when the vue_project_members_list feature flag was enabled and disabled. To do this a lot of the feature specs moved into two separate blocks, "when vue_project_members_list feature flag is disabled" and "when vue_project_members_list feature flag is enabled" block. This MR removes those blocks as they are no longer needed. In hindsight I shouldn't have wrapped the features specs in "when vue_project_members_list feature flag is enabled" block because now there are more changes and this is harder to review. It is hard to take an iterative approach to updating these feature specs because when we remove the feature flag the "when vue_project_members_list feature flag is disabled" feature specs will fail if not removed.
Screenshots (strongly suggested)
No visual changes, GIF below for context
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team