Skip to content

Allow project admin to read approval rules when project is archived

Brett Walker requested to merge 27934-approval-settings-api-fix into master

What does this MR do?

When a project is archived, you can't create MRs in the project. Permission create_merge_request_in was being checked to determine if the approval rules can be read. A project admin can edit those rules - they should be allowed to read them as well.

This MR allows a user with admin_project permissions to read the approval rules.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #27934 (closed)

Edited by Brett Walker

Merge request reports

Loading