Skip to content

Fix mismatched custom vue event names

Ezekiel Kigbo requested to merge fix-broken-vsa-label-filter into master

What does this MR do?

Ensures that the type of work filters for the tasks by type chart apply when they are changed.

Addresses #322632 (closed)

  • Ensures that all the custom event names are kebab cased for the type of work filters
  • Adds a feature spec to ensure we can detect future issues with the filters

Screenshots (strongly suggested)

No visual changes

Testing instructions

  1. Seed VSA data for a project, pick any project within a specific group and run:
$ VSA_SEED_PROJECT_ID=<project-id> FILTER=cycle_analytics SEED_VSA=true SEED_CUSTOMIZABLE_CYCLE_ANALYTICS=true bin/rake db:seed_fu
  1. Navigate to VSA for the relevant group that the project belongs to /groups/:group_id/-/analytics/value_stream_analytics
  2. Scroll to the bottom of the page once all data has loaded
  3. Click the gear icon to reveal the filters
  4. Edit the filters

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ezekiel Kigbo

Merge request reports

Loading