Skip to content

Add sort param to NotesFinder

Luke Duncalfe requested to merge 290116-notes-finder into master

What does this MR do?

This MR adds a sort param to NotesFinder, similar to other finders.

Previously NotesFinder would always sort notes by .fresh, however, in !52646 (merged) we introduced a change that required NotesFinder to order by id instead due to performance reasons. We could only achieve this by removing the .fresh scope with .reorder(nil) which required disabling a cop.

A follow-up issue #301037 (closed) was raised to add support for sort params for NotesFinder.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #290116 (closed)

Edited by Luke Duncalfe

Merge request reports

Loading