Add sort param to NotesFinder
What does this MR do?
This MR adds a sort
param to NotesFinder
, similar to other finders.
Previously NotesFinder
would always sort notes by .fresh
, however, in !52646 (merged) we introduced a change that required NotesFinder
to order by id
instead due to performance reasons. We could only achieve this by removing the .fresh
scope with .reorder(nil)
which required disabling a cop.
A follow-up issue #301037 (closed) was raised to add support for sort
params for NotesFinder
.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?- [-] I have included a changelog entry.
-
I have not included a changelog entry because ~"technical debt".
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Related to #290116 (closed)
Edited by Luke Duncalfe