Add commit_email to Users API
What does this MR do?
The User#commit_email
attribute has as much importance as public_email
(for example, it is also relevant to privacy), but is frequently overlooked. For example, the Users API does not support it, whereas it does support public_email
. This adds support for the User#commit_email
attribute to the Users API to make it equivalent to . Update: Because public_email
commit_email
is sensitive like email
, it is treated the same way as email
, meaning only visible to admins.
This also clarifies the documentation for creating users by removing public_email
, which is not officially supported by that endpoint.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #324105 (closed)