Project Settings Operations h4 Expand/Collapse 5/5
What does this MR do?
This MR adds classes settings-title
, js-settings-toggle
and js-settings-toggle-trigger-only
to the h4
headers in Project Settings / Operations header Status page. This enables the expand/collapse behavior on mouse-click / tap for the h4
headers.
Related to issue #205484 reported by @djannotta, and my previous MR !54114 (merged), !54115 (merged), !54117 (merged), !55228 (merged), !55229 (merged), !55230 (merged), !55231 (merged), !55232 (merged), !55233 (merged), !55234 (merged), !55235 (merged).
Project Settings Operations Headers (h4
elements) expand/collapse on mouse-click / tap, like using the Expand/Collapse button. Other h4
headers in other Project Settings pages do not expand/collapse on mouse-click / tap, but only using the Expand/Collapse button. This may seem inconsistent to the user.
The h4
headers of Project Settings General get the expand/collapse behavior through classes settings-title
, js-settings-toggle
and js-settings-toggle-trigger-only
.
- Part 1 of 5: !56269 (merged)
- Part 2 of 5: !56270 (merged)
- Part 3 of 5: !56273 (merged)
- Part 4 of 5: !56274 (merged)
- Part 4 of 5: !56275 (merged) (this MR)
Screenshots (strongly suggested)
(Copied from my first related MR !55228 (merged) for simplicity.)
Current behavior: no on-click / on-tap expand/collapse
Behavior after applying this MR: on-click / on-tap expand/collapse
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Apple Safari 13.1.2 (13609.3.5.1.5) -
Chromium Version 90.0.4409.0 -
Google Chrome 88.0.4324.146 -
Microsoft Edge 88.0.705.56 -
Mozilla Firefox 84.0.2
-
-
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team