Convert `members.scss` into page specific bundle
requested to merge 239850-convert-stylesheets-pages-members-scss-into-page-specific-bundle into master
📖 What does this MR do?
Related to #239850 (closed)
As part of an effort to reduce the size of our CSS bundle this MR converts members.scss
into page specific bundle so it is only loaded on the pages that need it.
See description in &3694 for documentation on how to create a page specific CSS bundle.
Style check
I manually checked all styles to ensure they are only used on the pages that we added add_page_specific_style 'page_bundles/members'
to.
To keep changes as small as possible all unused styles will be removed in a follow-up MR
📷 Screenshots
View | Before | After |
---|---|---|
Project members | ||
Group members | ||
Admin project | ||
Admin group |
🚦 Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because developer facing change.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman