Skip to content

Clean up integration form titles and password fields

What does this MR do?

  • Make some fields on Jenkins integration page required. This enables frontend validations and gives the user faster feedback while avoiding a slower and uglier backend validation.
  • Clean up password type fields when they are already filled in:
    • Add help text to "Leave blank to use your current password".
    • Add logic to have proper capitalization.
  • Add title field to a few integrations to properly capitalize some terms like API or URL.

Screenshots (strongly suggested)

Note: I have not included all integrations since most of the changes are quite trivial.

Integration Before After
Jira Jira_before Jira_after
Jenkins Jenkins_before Jenkins_after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #12975 (closed)

Edited by Justin Ho Tuan Duong

Merge request reports

Loading