Clean up integration form titles and password fields
requested to merge 12975-the-field-enter-new-password-in-service-templates-pages-should-show-asterisks-in-the-password into master
What does this MR do?
- Make some fields on Jenkins integration page required. This enables frontend validations and gives the user faster feedback while avoiding a slower and uglier backend validation.
- Clean up
password
type fields when they are already filled in:- Add help text to "Leave blank to use your current password".
- Add logic to have proper capitalization.
- Add
title
field to a few integrations to properly capitalize some terms likeAPI
orURL
.
Screenshots (strongly suggested)
Note: I have not included all integrations since most of the changes are quite trivial.
Integration | Before | After |
---|---|---|
Jira | ||
Jenkins |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #12975 (closed)
Edited by Justin Ho Tuan Duong