Skip to content

Remove pagination params from external approval rule creation

Max Woolf requested to merge 323360-change-pagination-params into master

What does this MR do?

  • Removes the pagination parameters from [POST] /projects/:id/external_approval_rules because they're unneccessary.
  • Adds a spec to assert that the pagination parameters still work for [GET] /projects/:id/external_approval_rules

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #323360 (closed)

Edited by Max Woolf

Merge request reports

Loading