Improve the MR analytics list query
What does this MR do?
This MR improves the MR analytics list query by rearranging the where
conditions on the query.
How to reproduce it:
- Enable the performance bar.
- Open: https://gitlab.com/gitlab-org/gitlab/-/analytics/merge_request_analytics
- Find the slowest Graphql endpoint in the dropdown and find the first query.
Slow query:
SELECT COUNT(*)
FROM
(SELECT 1 AS one
FROM "merge_requests"
INNER JOIN "merge_request_metrics" ON "merge_request_metrics"."merge_request_id" = "merge_requests"."id"
WHERE "merge_requests"."target_project_id" = 278964
AND "merge_requests"."target_project_id" = "merge_request_metrics"."target_project_id"
AND "merge_request_metrics"."merged_at" >= '2020-03-11 00:00:00'
AND "merge_request_metrics"."merged_at" <= '2021-03-11 00:00:00'
AND "merge_requests"."target_project_id" = "merge_request_metrics"."target_project_id"
LIMIT 21) subquery_for_count
Plan: https://explain.depesz.com/s/CxLS
Why is it slow?
The planner decides to hash join the matching merge_requests
rows with the merge_request_metrics
rows. After that it takes out 21 rows.
Improved query:
SELECT COUNT(*)
FROM
(SELECT 1 AS one
FROM "merge_requests"
INNER JOIN "merge_request_metrics" ON "merge_request_metrics"."merge_request_id" = "merge_requests"."id"
WHERE "merge_request_metrics"."target_project_id" = 278964
LIMIT 21) subquery_for_count
Plan: https://explain.depesz.com/s/ekJ3
The fix identifies if the MergeRequestsFinder
queries one project only. In that case the target_project_id
condition is removed from the original scope and added to the joined merge_request_metrics
scope. MergeRequest::Metrics
has the same target_project_id
column (de-normalization).
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team