Fix crashing in-product-marketing email worker
What does this MR do?
This is a temporary fix for the in-product-marketing-email worker.
It is a bug that consists of multiple layers. We expect to only have
root namespaces in onboarding_progresses. However, groups can be moved
to sub-groups. Threfore we also have sub-groups that would receieve the
emails.
This alone would not be an issue. But we need to call .root_ancestor
for these sub-groups and it doesn't play well together with
each_batches when there is an other JOIN condition on the namespace.
It currently generates a non-working query that fails.
To prevent this for now we do not send emails to sub-groups as a
temporary solution. In the long run, we need to remove all sub-groups
fron onboarding_progresses and fix the issue of calling
.root_ancestor in an each_batches call.
For more information please read through &5594
References: #324190 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it is behind a feature flag.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team