Fix: Update day grid to handle DLS
What does this MR do?
A tiny MVC for: https://gitlab.com/gitlab-org/gitlab/-/issues/323944 where we handle the generated gap for DLS by allowing a rotation assignee to "absorb" the extra/less space generated by a change in timezone via the offset. This works for both directions for the timezone offset(+/-).
We also update the shift pop over to use the locale offset rather than the selected timezone offset as when DLS changes, this becomes invalid. This lets us remove a selection of now-redundant code in the form of the selectedTimezone
injection
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?- [-] I have included a changelog entry.
-
I have not included a changelog entry because this is behind a feature flag .
- [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #323944
Edited by David O'Regan