Skip to content

Apply GraphQL complexity correctly for authenticated users

What does this MR do?

This sets the complexity on the query object during a Multiplex request, which seems to resolve the issue of custom complexity limits not being used during a request.

This probably isn't the right way to solve this, and im unsure of the unintended consequences of this change, but it may help unblock some teams running into the complexity limits. For example: !54892 (merged) is hitting the limit of 203 when we should be allowing at least 250.

Background

I did some research and a similar issue was fixed in a later version of GraphQL: Issue | Pull Request

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #324245 (closed)

Edited by Bob Van Landuyt

Merge request reports

Loading