Skip to content

Don't use HTTPS port for SSH

Mark Lapierre requested to merge ml-fix-2fa-ssh-test-on-review-apps into master

What does this MR do?

This fixes qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb when run on a review app (or any server using HTTPS).

The test used to fail with:

  2) Manage 2FA allows 2FA code recovery via ssh
     Failure/Error: output = ssh.reset_2fa_codes
     
     QA::Support::Run::CommandError:
       The command echo yes | ssh -i /tmp/id_f8f5eae57be77f9f20210310-23-1mp4hlk -o UserKnownHostsFile=/tmp/known_hosts_d7cc3fda1261ea6520210310-23-api0aa git@gitlab-review-ml-review-y8wjxt.gitlab-review.app -p 443 2fa_recovery_codes 2>&1 failed (255) with the following output:
       ssh_exchange_identification: Connection closed by remote host
     # ./qa/support/run.rb:36:in `run'
     # ./qa/support/ssh.rb:48:in `reset_2fa_codes'
     # ./qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb:27:in `block (4 levels) in <module:QA>'
     # ./qa/scenario/actable.rb:16:in `perform'
     # ./qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb:23:in `block (3 levels) in <module:QA>'

This was because it was trying to connect to the SSH server on port 443 instead of 22.

Does this MR meet the acceptance criteria?

Conformity

Edited by Mark Lapierre

Merge request reports