Skip to content

Fetch only detected and confirmed vulnerabilities

Savas Vedova requested to merge 288302-fix-vulnerability-query into master

What does this MR do?

This MR makes sure that we always fetch DETECTED and CONFIRMED vulnerabilities for Project Security Status statistics. This should be the correct behaviour - previously we fetched all vulnerabilities and displayed the wrong number.

In order to reproduce this, go to your Group => Security Dashboard and look for the Project Security Status widget. The numbers it contains should equal to the Vulnerability Report page inside the Project:

image

See that this image has 2 medium vulnerabilities and the image below has 2 medium vulnerabilities as well. Previously it used to show 4 because it was taking into account ALL vulnerabilities, not only the DETECTED and CONFIRMED.

Screenshots (strongly suggested)

There is no visual change but the number in question is this one:

vulnerability-grades

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #288302 (closed)

Edited by Savas Vedova

Merge request reports

Loading