Hide rotation restriction when rotation length is hourly
What does this MR do?
On call rotations can have a time restriction that limits them to certain hours in a day.
This restriction doesn't make sense for rotation of less than a day. So we hide that section of the form when the rotation length is 'hourly'.
issue: #262859 (closed)
discussion: #262859 (comment 500826685)
Follow-ups (Deferred because they will conflict with other in-flight MRs)
- Refactor form to use new
updateRotationForm
method. - Refactor form specs to use
trigger
instead of$emit
.
Testing notes
- Feature flag
:oncall_schedules_mvc
- Requires a GitLab Premium license or higher
Screenshots (strongly suggested)
before | after |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
- [n/a] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [n/a] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [n/a] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [n/a] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read