Skip to content

Fix bug in Gollum Tags filter

Francisco Javier López requested to merge fj-fix-bug-gollum-tag-filter into master

What does this MR do?

There is a problem in the GollumTagsFilter. If the tag references an existing file in the wiki repo, it adds an HTML image element and, in the data-src attribute, we pass the link.

Nevertheless, given the position the filter is added, the image is not properly rendered and we end up like:

Captura_de_pantalla_2021-03-15_a_las_11.54.30

Instead, we can take advantage of the existing ImageLazyLoad filter. In order to do that, we need to install the GollumTagsFilter before ImageLazyLoad and populate the src attribute instead of data-src.

The result after the fix is:

image

Does this MR meet the acceptance criteria?

Conformity

Refs #20150 (closed)

Edited by Francisco Javier López

Merge request reports

Loading