Skip to content

Fix TODO-ed rubocop violations

Alex Kalderimis requested to merge ajk-rubcop-violations-MAR into master

What does this MR do?

This fixes a bunch of TODO-ed rubocop violations, discovered with the use of REVEAL_RUBOCOP_TODO=1.

This also includes a change to the GraphQL description cop to allow fields that take all their metadata from the resolver, without overriding the description.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports

Loading