Exclude the pipeline configuration path from form submission if it is disabled
What does this MR do?
With the backend changes being made in !56672 (comment 529827375) we need to change the frontend implementation to make sure we exclude the pipelineConfigurationFullPath
from the form submission process if the feature is not enabled.
Screenshots (strongly suggested)
No visual changes
Without pipeline feature | With pipeline feature |
---|---|
Screen_Recording_2021-03-16_at_10.51.25 | Screen_Recording_2021-03-16_at_10.53.06 |
Setup & Testing
Note: To exclude the pipeline feature you will need to cherry-pick from !56672 (commits) otherwise the pipeline is tied directly to ff_custom_compliance_frameworks
instead.
- Enable the development feature flag in rails console:
Feature.enable(:ff_custom_compliance_frameworks)
and make sure you are at least on GitLab Premium - Navigate to a group's general settings
[GDK_HOST]/groups/gitlab-org/-/edit#js-compliance-frameworks-settings
- Add and edit a compliance framework and confirm it saves the values
- Enable the development feature flag in rails console:
Feature.enable(:ff_evaluate_group_level_compliance_pipeline)
and make sure you are at least on GitLab Ultimate - The compliance pipeline configuration file needs an accessible
.y[a]ml
file for the validation to pass, so you will need to add a.y[a]ml
file to a project first - Add and edit a compliance framework and confirm it saves the values
- An example format for the pipeline configuration file path:
test.yml@gitlab-org/gitlab-test
- An example format for the pipeline configuration file path:
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this feature is behind a feature flag.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert Hunt