Skip to content

Fix error when default VS is requested

Adam Hegyi requested to merge 324673-fix-error-on-default-vsa-page into master

What does this MR do?

Fix error when default stage page is refreshed. Default stage object by default is not persisted in the DB so we need to build an in-memory object. (we already do this for other endpoints)

How to reproduce it:

  1. GDK, freshly seeded with ultimate plan.
  2. Visit: http://localhost:3000/groups/flightjs/-/analytics/value_stream_analytics?created_after=2021-02-28&created_before=2021-03-29&value_stream_id=default
  3. You should see error in the rails logs.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #324673 (closed)

Edited by Mark Chao

Merge request reports

Loading