Skip to content

Fix: update oncall rotation name to truncate

David O'Regan requested to merge 324714-long-name-overlap into master

What does this MR do?

A tiny MVC for: #324714 (closed) where we truncate long rotation names and add a supporting tool tip for hover.

How/What to test

This feature needs the minimal license is GitLab Premium 👀

To validate this merge:

  • Navigate to Operations => On-call Schedules or direct link is your_project/-/oncall_schedules e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules.
  • Click "Add schedule on empty state"
  • Add a base schedule
  • Click "Add a rotation"
  • Add a base rotation with a long name
  • Verify the new rotation name is truncate and has a tooltip for hover

Screenshots (strongly suggested)

Before After
Screenshot_2021-03-16_at_08.57.18 Screenshot_2021-03-16_at_08.58.10

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #324714 (closed)

Edited by David O'Regan

Merge request reports

Loading