Skip to content

Fix the GraphQL logs for multiplex queries

Mehmet Emin INAC requested to merge fix_graphql_logs_for_multiplex_requests into master

What does this MR do?

The previous implementation was using the operationName parameter received by the controller but this parameter is nil for multiplex queries as there are multiple queries to execute in one request. With this change, we are now relying on an analyzer to get the operation names for all types of queries.

This will change the graphql attribute of the JSON object from an object to an array of objects but the objects in the array will have the same keys and by default, all the keys can hold an array of things on ElasticSearch so this shouldn't break the auto-indexing feature.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mehmet Emin INAC

Merge request reports

Loading