Skip to content

Reduce N+1 queries from Projects::MergeRequestsController#index action related to protected branches and code owners

What does this MR do?

On the merge request index page, checking if a branch requires code owner's approval often results in an N+1. Temporarily caching the result can save at least a couple queries during a full page load.

Screenshots (strongly suggested)

Without cache:

without

With cache:

with

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #321935 (closed)

Edited by Gary Holtz

Merge request reports

Loading