Skip to content

Add glfilteredsearch to group boards

Scott Stern requested to merge ss/add-labels-to-filtered-search into master

What does this MR do?

This MR includes:

  • Rendering Author Token and Fetching Authors from Graphql
  • Rendering Label Token and Fetching Labels from Graphql

2021-03-22_16.30.25

What this MR doesnt include:

  • When you click enter or search it does NOT update the board

What needs to happen next:

  • Error state handling when this request fails
  • On fetch of Authors, we need to add current_user to the top of the list per the existing functionality
  • Add any additional token we want for this board
  • Make sure UX/Product is content with the new filtered search and document fast follows that need to occur if any in gitlab ui.

Architecture: what needs to happen next:

  • Consolidate the components to use a wrapper component like discussed with @ntepluhina
  • Create an issue to discuss consolidating api vs graphql token components.
  • Add a frontend integration spec for epic_filtered_search.vue. It honestly was very complicated and weird to test each component created in the MR. It feels like a frontend integration spec would cover most cases. Because at the gitlab/ui level we are unit testing...feel free to leave comments on this below.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Scott Stern

Merge request reports

Loading